From d6473ba93051cced45e182af602677a5b087169c Mon Sep 17 00:00:00 2001
From: trafficlunar <trafficlunar@proton.me>
Date: Fri, 27 Dec 2024 21:42:10 +0000
Subject: [PATCH] fix: change aspect ratio calculations in `OpenImage` dialog

---
 src/components/dialogs/OpenImage.tsx | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/src/components/dialogs/OpenImage.tsx b/src/components/dialogs/OpenImage.tsx
index e4c60df..9753eb1 100644
--- a/src/components/dialogs/OpenImage.tsx
+++ b/src/components/dialogs/OpenImage.tsx
@@ -37,17 +37,11 @@ function OpenImage({ close }: DialogProps) {
 		}
 	}, [acceptedFiles]);
 
-	const onDimensionChange = (e: React.ChangeEvent<HTMLInputElement>, isWidth: boolean) => {
+	const onDimensionChange = (e: React.ChangeEvent<HTMLInputElement>) => {
 		const newDimension = Number(e.target.value);
 		if (newDimension < 1 || newDimension > 10000) return;
 
-		setImageDimensions(() => {
-			if (isWidth) {
-				return { width: newDimension, height: Math.round(newDimension / aspectRatio) };
-			} else {
-				return { width: Math.round(newDimension / aspectRatio), height: newDimension };
-			}
-		});
+		setImageDimensions(() => ({ width: newDimension, height: Math.round(newDimension / aspectRatio) }));
 	};
 
 	const onSubmit = () => {
@@ -99,18 +93,12 @@ function OpenImage({ close }: DialogProps) {
 
 								<div>
 									<Label htmlFor="width">Width (blocks)</Label>
-									<Input type="number" id="width" placeholder="Width" value={imageDimensions.width} onChange={(e) => onDimensionChange(e, true)} />
+									<Input type="number" id="width" placeholder="Width" value={imageDimensions.width} onChange={(e) => onDimensionChange(e)} />
 								</div>
 
 								<div>
 									<Label htmlFor="height">Height (blocks)</Label>
-									<Input
-										type="number"
-										id="height"
-										placeholder="Height"
-										value={imageDimensions.height}
-										onChange={(e) => onDimensionChange(e, false)}
-									/>
+									<Input type="number" id="height" placeholder="Height" value={imageDimensions.height} onChange={(e) => onDimensionChange(e)} />
 								</div>
 							</div>
 						</>