trafficlunar/tomodachi-share
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: rate limit on images not working properly

Browse source
This commit is contained in:
trafficlunar 2025-07-26 15:50:20 +01:00
parent e8f211733f
commit 701f038971
2 changed files with 22 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/app/mii/[id]/image/route.ts
View file

@ -1,4 +1,4 @@
import { NextRequest, NextResponse } from "next/server";
import { NextRequest } from "next/server";
import fs from "fs/promises";
import path from "path";
@ -78,6 +78,8 @@ export async function GET(request: NextRequest, { params }: { params: Promise<{
}
}
if (!buffer) return rateLimit.sendResponse({ error: "Image not found" }, 404);
// Set the file name for the metadata image in the response for SEO
if (mii && imageType === "metadata") {
const slugify = (str: string) =>
@ -92,20 +94,16 @@ export async function GET(request: NextRequest, { params }: { params: Promise<{
const filename = `${name}-mii-${tags}-by-${username}.png`;
return new NextResponse(buffer, {
headers: {
"Content-Type": "image/png",
"Content-Disposition": `inline; filename="${filename}"`,
"Cache-Control": "public, max-age=31536000",
},
return rateLimit.sendResponse(buffer, 200, {
"Content-Type": "image/png",
"Content-Disposition": `inline; filename="${filename}"`,
"Cache-Control": "public, max-age=31536000",
});
}
return new NextResponse(buffer, {
headers: {
"Content-Type": "image/webp",
"X-Robots-Tag": "noindex, noimageindex, nofollow",
"Cache-Control": "no-store",
},
return rateLimit.sendResponse(buffer, 200, {
"Content-Type": "image/webp",
"X-Robots-Tag": "noindex, noimageindex, nofollow",
"Cache-Control": "no-store",
});
}

14
src/lib/rate-limit.ts
View file

@ -64,16 +64,24 @@ export class RateLimit {
}
// Attach rate limit headers to a response
sendResponse(message: object, status: number = 200): NextResponse<object> {
const response = NextResponse.json(message, { status });
sendResponse(body: object | Buffer, status: number = 200, headers?: HeadersInit): NextResponse<object | unknown> {
let response: NextResponse;
if (Buffer.isBuffer(body)) {
response = new NextResponse(body, { status, headers });
} else {
response = NextResponse.json(body, { status, headers });
}
response.headers.set("X-RateLimit-Limit", this.data.limit.toString());
response.headers.set("X-RateLimit-Remaining", this.data.remaining.toString());
response.headers.set("X-RateLimit-Expires", this.data.expires.toString());
return response;
}
// Handle both functions above and identifier in one
async handle(): Promise<NextResponse<object> | undefined> {
async handle(): Promise<NextResponse<object | unknown> | undefined> {
const session = await auth();
const ip = this.request.headers.get("CF-Connecting-IP") || this.request.headers.get("X-Forwarded-For")?.split(",")[0];
const identifier = (session ? session.user.id : ip) ?? "null";