From 949e86111a2457f4d2e79bef6e7757605a1518e3 Mon Sep 17 00:00:00 2001
From: trafficlunar <hello@trafficlunar.net>
Date: Sun, 5 Apr 2026 21:45:57 +0100
Subject: [PATCH] fix: voice and personality issues

---
 src/app/api/mii/[id]/edit/route.ts                  | 2 +-
 src/components/mii/voice-viewer.tsx                 | 4 ++--
 src/components/submit-form/mii-editor/tabs/misc.tsx | 1 -
 src/lib/switch.ts                                   | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/app/api/mii/[id]/edit/route.ts b/src/app/api/mii/[id]/edit/route.ts
index 926fb3e..7cdad9d 100644
--- a/src/app/api/mii/[id]/edit/route.ts
+++ b/src/app/api/mii/[id]/edit/route.ts
@@ -43,7 +43,7 @@ export async function PATCH(request: NextRequest, { params }: { params: Promise<
 	if (!session) return NextResponse.json({ error: "Unauthorized" }, { status: 401 });
 	Sentry.setUser({ id: session.user?.id, name: session.user?.name });
 
-	const rateLimit = new RateLimit(request, 2); // no grouped pathname; edit each mii 2 times a minute
+	const rateLimit = new RateLimit(request, 6); // no grouped pathname; edit each mii 2 times a minute
 	const check = await rateLimit.handle();
 	if (check) return check;
 
diff --git a/src/components/mii/voice-viewer.tsx b/src/components/mii/voice-viewer.tsx
index e709fde..a4660ff 100644
--- a/src/components/mii/voice-viewer.tsx
+++ b/src/components/mii/voice-viewer.tsx
@@ -27,10 +27,10 @@ export default function VoiceViewer({ data, onChange, onClickTone }: Props) {
 							min={0}
 							max={50}
 							step={1}
-							value={data[label as keyof typeof data] ?? 25}
+							value={data[label.toLowerCase() as keyof typeof data] ?? 25}
 							disabled={!onChange}
 							onChange={(e) => {
-								if (onChange) onChange(e, label);
+								if (onChange) onChange(e, label.toLowerCase());
 							}}
 						/>
 						<div className="absolute h-4 w-1.5 rounded bg-orange-400 z-0"></div>
diff --git a/src/components/submit-form/mii-editor/tabs/misc.tsx b/src/components/submit-form/mii-editor/tabs/misc.tsx
index caa02bd..6e50ad6 100644
--- a/src/components/submit-form/mii-editor/tabs/misc.tsx
+++ b/src/components/submit-form/mii-editor/tabs/misc.tsx
@@ -223,7 +223,6 @@ export default function HeadTab({ instructions }: Props) {
 							instructions.current.personality = updated;
 							return updated;
 						});
-						instructions.current.personality = personality;
 					}}
 				/>
 			</div>
diff --git a/src/lib/switch.ts b/src/lib/switch.ts
index ef32bff..e8cc21c 100644
--- a/src/lib/switch.ts
+++ b/src/lib/switch.ts
@@ -7,7 +7,7 @@ export function minifyInstructions(instructions: Partial<SwitchMiiInstructions>)
 		for (const key in object) {
 			const value = object[key as keyof SwitchMiiInstructions];
 
-			if (!value || (DEFAULT_ZERO_FIELDS.has(key) && value === 0)) {
+			if (value === null || value === undefined || (DEFAULT_ZERO_FIELDS.has(key) && value === 0)) {
 				delete object[key as keyof SwitchMiiInstructions];
 				continue;
 			}