From 971f0c3c00654d8680df7652d46f932c264d3fcf Mon Sep 17 00:00:00 2001
From: trafficlunar <hello@trafficlunar.net>
Date: Sun, 29 Mar 2026 00:34:30 +0000
Subject: [PATCH] fix: camera problems

---
 src/components/submit-form/camera.tsx         | 44 ++++++++++++++-----
 .../submit-form/switch-file-upload.tsx        | 18 ++++----
 2 files changed, 41 insertions(+), 21 deletions(-)

diff --git a/src/components/submit-form/camera.tsx b/src/components/submit-form/camera.tsx
index 5045cd6..36780c3 100644
--- a/src/components/submit-form/camera.tsx
+++ b/src/components/submit-form/camera.tsx
@@ -10,11 +10,12 @@ import { useSelect } from "downshift";
 interface Props {
 	isOpen: boolean;
 	setIsOpen: React.Dispatch<React.SetStateAction<boolean>>;
+	onCapture?: () => void;
 	setImage?: React.Dispatch<React.SetStateAction<string | undefined>>;
 	setQrBytesRaw?: React.Dispatch<React.SetStateAction<number[]>>;
 }
 
-export default function Camera({ isOpen, setIsOpen, setImage, setQrBytesRaw }: Props) {
+export default function Camera({ isOpen, setIsOpen, onCapture, setImage, setQrBytesRaw }: Props) {
 	const [isVisible, setIsVisible] = useState(false);
 
 	const [permissionGranted, setPermissionGranted] = useState<boolean | null>(null);
@@ -23,6 +24,7 @@ export default function Camera({ isOpen, setIsOpen, setImage, setQrBytesRaw }: P
 	const [selectedDeviceId, setSelectedDeviceId] = useState<string | null>(null);
 
 	const videoRef = useRef<HTMLVideoElement>(null);
+	const streamRef = useRef<MediaStream | null>(null);
 	const requestRef = useRef<number>(null);
 	const canvasRef = useRef<HTMLCanvasElement>(null);
 
@@ -65,6 +67,7 @@ export default function Camera({ isOpen, setIsOpen, setImage, setQrBytesRaw }: P
 
 		if (setImage) {
 			setImage(canvas.toDataURL());
+			if (onCapture) onCapture();
 			close();
 			return;
 		}
@@ -89,14 +92,34 @@ export default function Camera({ isOpen, setIsOpen, setImage, setQrBytesRaw }: P
 
 		navigator.mediaDevices
 			.getUserMedia({ video: true, audio: false })
-			.then(() => setPermissionGranted(true))
+			.then((stream) => {
+				// immediately stop this temp stream
+				stream.getTracks().forEach((track) => track.stop());
+				setPermissionGranted(true);
+			})
 			.catch((err) => {
 				setPermissionGranted(false);
 				console.error("An error occurred trying to access the camera", err);
 			});
 	};
 
+	const stopCamera = () => {
+		if (requestRef.current) {
+			cancelAnimationFrame(requestRef.current);
+			requestRef.current = null;
+		}
+		if (videoRef.current) {
+			videoRef.current.pause();
+			videoRef.current.srcObject = null;
+		}
+		if (streamRef.current) {
+			streamRef.current.getTracks().forEach((track) => track.stop());
+			streamRef.current = null;
+		}
+	};
+
 	const close = () => {
+		stopCamera();
 		setIsVisible(false);
 		setTimeout(() => {
 			setIsOpen(false);
@@ -132,6 +155,7 @@ export default function Camera({ isOpen, setIsOpen, setImage, setQrBytesRaw }: P
 			})
 			.then((stream) => {
 				if (!stream || !videoRef.current) return;
+				streamRef.current = stream;
 				videoRef.current.srcObject = stream;
 				videoRef.current.play();
 			})
@@ -141,16 +165,9 @@ export default function Camera({ isOpen, setIsOpen, setImage, setQrBytesRaw }: P
 
 		// cleanup
 		return () => {
-			if (requestRef.current) {
-				cancelAnimationFrame(requestRef.current);
-			}
-			if (videoRef.current?.srcObject) {
-				const stream = videoRef.current.srcObject as MediaStream;
-				stream.getTracks().forEach((track) => track.stop());
-				videoRef.current.srcObject = null;
-			}
+			stopCamera();
 		};
-	}, [isOpen, permissionGranted, selectedDeviceId, takePicture]);
+	}, [isOpen, permissionGranted, selectedDeviceId]);
 
 	return (
 		<div className={`fixed inset-0 h-[calc(100%-var(--header-height))] top-(--header-height) flex items-center justify-center z-40 ${!isOpen ? "hidden" : ""}`}>
@@ -218,7 +235,10 @@ export default function Camera({ isOpen, setIsOpen, setImage, setQrBytesRaw }: P
 						</div>
 					)}
 
-					<video ref={videoRef} className={`size-full rounded-2xl border-2 border-amber-500 max-h-96 ${setQrBytesRaw ? "object-cover" : ""}`} />
+					<div className="rounded-2xl border-2 border-amber-500 max-h-96 flex justify-center items-center overflow-hidden">
+						<img src="/loading.svg" alt="loading indicator" width={256} height={256} className="absolute" />
+						<video ref={videoRef} className={`size-full z-10 ${setQrBytesRaw ? "object-cover" : ""}`} />
+					</div>
 					{setQrBytesRaw && <QrFinder />}
 					<canvas ref={canvasRef} className="hidden" />
 				</div>
diff --git a/src/components/submit-form/switch-file-upload.tsx b/src/components/submit-form/switch-file-upload.tsx
index 419825d..b774e39 100644
--- a/src/components/submit-form/switch-file-upload.tsx
+++ b/src/components/submit-form/switch-file-upload.tsx
@@ -17,7 +17,6 @@ interface Props {
 export default function SwitchFileUpload({ text, forceCrop, image, setImage }: Props) {
 	const [isCameraOpen, setIsCameraOpen] = useState(false);
 	const [isCropOpen, setIsCropOpen] = useState(false);
-	const [hasImage, setHasImage] = useState(false);
 
 	const handleDrop = useCallback(
 		(acceptedFiles: FileWithPath[]) => {
@@ -26,7 +25,6 @@ export default function SwitchFileUpload({ text, forceCrop, image, setImage }: P
 			const reader = new FileReader();
 			reader.onload = async (event) => {
 				setImage(event.target!.result as string);
-				setHasImage(true);
 				if (forceCrop) setIsCropOpen(true);
 			};
 			reader.readAsDataURL(file);
@@ -34,16 +32,11 @@ export default function SwitchFileUpload({ text, forceCrop, image, setImage }: P
 		[setImage],
 	);
 
-	useEffect(() => {
-		if (!isCameraOpen) return;
-		if (forceCrop) setIsCropOpen(true);
-	}, [isCameraOpen]);
-
 	return (
 		<div className="max-w-md w-full flex flex-col items-center gap-2">
 			<Dropzone onDrop={handleDrop} options={{ maxFiles: 1 }}>
 				<p className="text-center text-sm">
-					{!hasImage ? (
+					{!image ? (
 						<>
 							Drag and drop {text}
 							<br />
@@ -66,7 +59,14 @@ export default function SwitchFileUpload({ text, forceCrop, image, setImage }: P
 				Crop Image
 			</button>
 
-			<Camera isOpen={isCameraOpen} setIsOpen={setIsCameraOpen} setImage={setImage} />
+			<Camera
+				isOpen={isCameraOpen}
+				setIsOpen={setIsCameraOpen}
+				setImage={setImage}
+				onCapture={() => {
+					if (forceCrop) setIsCropOpen(true);
+				}}
+			/>
 			<CropPortrait isOpen={isCropOpen} setIsOpen={setIsCropOpen} image={image} setImage={setImage} />
 		</div>
 	);