From a9dcb21c20212e341f5a430d4ddbedb74eb02d85 Mon Sep 17 00:00:00 2001
From: Landon & Emma <80786423+LandonAndEmma@users.noreply.github.com>
Date: Wed, 8 Apr 2026 10:59:44 -0400
Subject: [PATCH] Feat: Add Better Sliders

Fix #19
---
 src/components/mii/instructions.tsx           |  22 ++--
 src/components/mii/voice-viewer.tsx           |  53 ++++----
 .../mii-editor/enhanced-slider.tsx            | 123 ++++++++++++++++++
 .../submit-form/mii-editor/tabs/misc.tsx      |  71 ++++------
 4 files changed, 183 insertions(+), 86 deletions(-)
 create mode 100644 src/components/submit-form/mii-editor/enhanced-slider.tsx

diff --git a/src/components/mii/instructions.tsx b/src/components/mii/instructions.tsx
index 2e13647..a1b9bda 100644
--- a/src/components/mii/instructions.tsx
+++ b/src/components/mii/instructions.tsx
@@ -200,24 +200,18 @@ export default function MiiInstructions({ instructions }: Props) {
 
 					{height && (
 						<div className="flex mb-1">
-							<label htmlFor="height" className="w-16">
-								Height
-							</label>
-							<div className="relative h-5 flex justify-center items-center">
-								<input id="height" type="range" min={0} max={128} step={1} disabled value={height} />
-								<div className="absolute h-4 w-1.5 rounded bg-orange-300 z-0"></div>
-							</div>
+							<span className="w-16">Height</span>
+							<span className="font-semibold text-orange-600">
+								{height === 64 ? "0" : height > 64 ? `+${height - 64}` : `${height - 64}`}
+							</span>
 						</div>
 					)}
 					{weight && (
 						<div className="flex">
-							<label htmlFor="weight" className="w-16">
-								Weight
-							</label>
-							<div className="relative h-5 flex justify-center items-center">
-								<input id="weight" type="range" min={0} max={128} step={1} disabled value={weight} />
-								<div className="absolute h-4 w-1.5 rounded bg-orange-300 z-0"></div>
-							</div>
+							<span className="w-16">Weight</span>
+							<span className="font-semibold text-orange-600">
+								{weight === 64 ? "0" : weight > 64 ? `+${weight - 64}` : `${weight - 64}`}
+							</span>
 						</div>
 					)}
 					{birthday && (
diff --git a/src/components/mii/voice-viewer.tsx b/src/components/mii/voice-viewer.tsx
index d809588..d51cb99 100644
--- a/src/components/mii/voice-viewer.tsx
+++ b/src/components/mii/voice-viewer.tsx
@@ -1,48 +1,45 @@
 "use client";
-
 import { SwitchMiiInstructions } from "@/types";
-import { ChangeEvent } from "react";
+import EnhancedSlider from "@/components/submit-form/mii-editor/enhanced-slider";
 
 interface Props {
 	data: SwitchMiiInstructions["voice"];
-	onChange?: (e: ChangeEvent<HTMLInputElement, HTMLInputElement>, label: string) => void;
+	onChange?: (value: number, label: string) => void;
 	onClickTone?: (i: number) => void;
 }
 
-const VOICE_SETTINGS: string[] = ["Speed", "Pitch", "Depth", "Delivery"];
+const VOICE_SETTINGS = ["Speed", "Pitch", "Depth", "Delivery"];
 
 export default function VoiceViewer({ data, onChange, onClickTone }: Props) {
 	return (
-		<div className="flex flex-col gap-1">
-			{VOICE_SETTINGS.map((label) => (
-				<div key={label} className="relative flex gap-3">
-					<label htmlFor={label} className="text-sm w-14">
-						{label}
-					</label>
-					<div className="relative h-5 flex justify-center items-center">
-						<input
-							type="range"
-							name={label}
-							className="grow z-10"
-							min={0}
-							max={50}
-							step={1}
-							value={data[label.toLowerCase() as keyof typeof data] ?? 25}
-							disabled={!onChange}
-							onChange={(e) => {
-								if (onChange) onChange(e, label.toLowerCase());
-							}}
-						/>
-						<div className="absolute h-4 w-1.5 rounded bg-orange-300 z-0"></div>
+		<div className="flex flex-col gap-2">
+			{VOICE_SETTINGS.map((label) => {
+				const value = data[label.toLowerCase() as keyof typeof data] ?? 25;
+				return onChange ? (
+					<EnhancedSlider
+						key={label}
+						label={label}
+						value={value}
+						onChange={(v) => onChange?.(v, label.toLowerCase())}
+						min={0}
+						max={50}
+						mid={25}
+					/>
+				) : (
+					<div key={label} className="flex">
+						<span className="w-14">{label}</span>
+						<span className="font-semibold text-orange-600">
+							{value === 25 ? "0" : value > 25 ? `+${value - 25}` : `${value - 25}`}
+						</span>
 					</div>
-				</div>
-			))}
+				);
+			})}
 
 			<div className="flex gap-3">
 				<label htmlFor="delivery" className="text-sm w-14">
 					Tone
 				</label>
-				<div className="grid grid-cols-6 gap-1 grow">
+				<div className="grid grid-cols-6 gap-1 min-w-[200px]">
 					{Array.from({ length: 6 }).map((_, i) => (
 						<button
 							type="button"
diff --git a/src/components/submit-form/mii-editor/enhanced-slider.tsx b/src/components/submit-form/mii-editor/enhanced-slider.tsx
new file mode 100644
index 0000000..695e399
--- /dev/null
+++ b/src/components/submit-form/mii-editor/enhanced-slider.tsx
@@ -0,0 +1,123 @@
+import { Icon } from "@iconify/react";
+import React, { useState, useEffect } from "react";
+
+interface SliderProps {
+	label: string;
+	value: number;
+	onChange: (value: number) => void;
+	min?: number;
+	max?: number;
+	mid?: number;
+	step?: number;
+	className?: string;
+}
+
+export default function EnhancedSlider({
+	label,
+	value,
+	onChange,
+	min = 0,
+	max = 128,
+	mid = 64,
+	step = 1,
+	className = "",
+}: SliderProps) {
+	const [internalValue, setInternalValue] = useState(value);
+
+	// Sync with external value
+	React.useEffect(() => {
+		setInternalValue(value);
+	}, [value]);
+
+	const handleChange = (newValue: number) => {
+		const clampedValue = Math.min(max, Math.max(min, newValue));
+		setInternalValue(clampedValue);
+		onChange(clampedValue);
+	};
+
+	const nudge = (direction: number) => {
+		const newValue = internalValue + (direction * step);
+		handleChange(newValue);
+	};
+
+	const displayValue = internalValue - mid;
+	const displayText = displayValue > 0 ? `+${displayValue}` : displayValue.toString();
+
+	return (
+		<div className={`w-full ${className}`}>
+			<div className="flex justify-between items-center mb-2 relative">
+				<h3 className="text-sm font-semibold">{label}</h3>
+				<span className="absolute left-1/2 transform -translate-x-1/2 text-xs font-bold text-orange-600 bg-white px-2 py-1 rounded-full shadow-sm">
+					{displayText}
+				</span>
+			</div>
+			<div className="flex items-center gap-2">
+				<button
+					type="button"
+					onClick={() => nudge(-1)}
+					disabled={internalValue <= min}
+					className="bg-white border-2 border-orange-400 text-orange-400 font-bold w-8 h-8 rounded-lg cursor-pointer flex items-center justify-center flex-shrink-0 transition-transform active:scale-95 disabled:opacity-30 disabled:cursor-not-allowed hover:bg-orange-50"
+					aria-label={`Decrease ${label}`}
+				>
+					<Icon icon="mdi:chevron-left" width="16" height="16" />
+				</button>
+				
+				<div className="relative flex-1 h-8 flex items-center">
+					{/* Tick mark at center */}
+					<div className="absolute left-1/2 top-1/2 transform -translate-x-1/2 -translate-y-1/2 w-0.5 h-3 bg-orange-400 rounded z-10 opacity-60"></div>
+					
+					<input
+						type="range"
+						min={min}
+						max={max}
+						step={step}
+						value={internalValue}
+						onChange={(e) => handleChange(Number(e.target.value))}
+						className="w-full h-2 bg-orange-200 rounded-lg appearance-none cursor-pointer slider-thumb"
+						style={{
+							background: `linear-gradient(to right, #fb923c 0%, #fb923c ${((internalValue - min) / (max - min)) * 100}%, #fed7aa ${((internalValue - min) / (max - min)) * 100}%, #fed7aa 100%)`
+						}}
+					/>
+				</div>
+				
+				<button
+					type="button"
+					onClick={() => nudge(1)}
+					disabled={internalValue >= max}
+					className="bg-white border-2 border-orange-400 text-orange-400 font-bold w-8 h-8 rounded-lg cursor-pointer flex items-center justify-center flex-shrink-0 transition-transform active:scale-95 disabled:opacity-30 disabled:cursor-not-allowed hover:bg-orange-50"
+					aria-label={`Increase ${label}`}
+				>
+					<Icon icon="mdi:chevron-right" width="16" height="16" />
+				</button>
+			</div>
+			
+			<style jsx>{`
+				.slider-thumb::-webkit-slider-thumb {
+					-webkit-appearance: none;
+					appearance: none;
+					width: 18px;
+					height: 18px;
+					border-radius: 50%;
+					background: #fb923c;
+					border: 2px solid #ea580c;
+					cursor: pointer;
+					box-shadow: 0 1px 3px rgba(0, 0, 0, 0.2);
+				}
+				
+				.slider-thumb::-moz-range-thumb {
+					width: 18px;
+					height: 18px;
+					border-radius: 50%;
+					background: #fb923c;
+					border: 2px solid #ea580c;
+					cursor: pointer;
+					box-shadow: 0 1px 3px rgba(0, 0, 0, 0.2);
+				}
+				
+				.slider-thumb:focus {
+					outline: none;
+				}
+			`}</style>
+		</div>
+	);
+}
diff --git a/src/components/submit-form/mii-editor/tabs/misc.tsx b/src/components/submit-form/mii-editor/tabs/misc.tsx
index 2cfaf1d..31aece1 100644
--- a/src/components/submit-form/mii-editor/tabs/misc.tsx
+++ b/src/components/submit-form/mii-editor/tabs/misc.tsx
@@ -1,17 +1,16 @@
 import { useState } from "react";
 import { MiiGender } from "@prisma/client";
-
 import DatingPreferencesViewer from "@/components/mii/dating-preferences";
 import VoiceViewer from "@/components/mii/voice-viewer";
 import PersonalityViewer from "@/components/mii/personality-viewer";
-
+import EnhancedSlider from "@/components/submit-form/mii-editor/enhanced-slider";
 import { SwitchMiiInstructions } from "@/types";
 
 interface Props {
 	instructions: React.RefObject<SwitchMiiInstructions>;
 }
 
-export default function HeadTab({ instructions }: Props) {
+export default function MiscTab({ instructions }: Props) {
 	const [height, setHeight] = useState(instructions.current.height ?? 64);
 	const [weight, setWeight] = useState(instructions.current.weight ?? 64);
 	const [datingPreferences, setDatingPreferences] = useState<MiiGender[]>(instructions.current.datingPreferences ?? []);
@@ -50,47 +49,31 @@ export default function HeadTab({ instructions }: Props) {
 						</div>
 
 						<div className="flex flex-col">
-							<label htmlFor="height" className="text-sm">
-								Height
-							</label>
-							<div className="relative h-5 flex justify-center items-center">
-								<input
-									type="range"
-									id="height"
-									className="grow z-10"
-									min={0}
-									max={128}
-									step={1}
-									value={height}
-									onChange={(e) => {
-										setHeight(e.target.valueAsNumber);
-										instructions.current.height = e.target.valueAsNumber;
-									}}
-								/>
-								<div className="absolute h-4 w-1.5 rounded bg-orange-300 z-0"></div>
-							</div>
+							<EnhancedSlider
+								label="Height"
+								value={height}
+								onChange={(v) => {
+									setHeight(v);
+									instructions.current.height = v;
+								}}
+								min={0}
+								max={128}
+								mid={64}
+							/>
 						</div>
 
 						<div className="flex flex-col">
-							<label htmlFor="weight" className="text-sm">
-								Weight
-							</label>
-							<div className="relative h-5 flex justify-center items-center">
-								<input
-									type="range"
-									id="weight"
-									className="grow z-10"
-									min={0}
-									max={128}
-									step={1}
-									value={weight}
-									onChange={(e) => {
-										setWeight(e.target.valueAsNumber);
-										instructions.current.weight = e.target.valueAsNumber;
-									}}
-								/>
-								<div className="absolute h-4 w-1.5 rounded bg-orange-300 z-0"></div>
-							</div>
+							<EnhancedSlider
+								label="Weight"
+								value={weight}
+								onChange={(v) => {
+									setWeight(v);
+									instructions.current.weight = v;
+								}}
+								min={0}
+								max={128}
+								mid={64}
+							/>
 						</div>
 
 						<div className="flex items-center gap-4 text-zinc-500 text-sm font-medium mt-1.5 mb-2">
@@ -122,9 +105,9 @@ export default function HeadTab({ instructions }: Props) {
 
 						<VoiceViewer
 							data={voice}
-							onChange={(e, label) => {
-								setVoice((p) => ({ ...p, [label]: e.target.valueAsNumber }));
-								instructions.current.voice[label as keyof typeof voice] = e.target.valueAsNumber;
+							onChange={(v, label) => {
+								setVoice((p) => ({ ...p, [label]: v }));
+								instructions.current.voice[label as keyof typeof voice] = v;
 							}}
 							onClickTone={(i) => {
 								setVoice((p) => ({ ...p, tone: i }));