feat: better submit error messages

This commit is contained in:
trafficlunar 2026-03-27 23:48:00 +00:00
parent cd6f4b948d
commit d0f32333e9
2 changed files with 16 additions and 6 deletions

View file

@ -118,7 +118,9 @@ export async function POST(request: NextRequest) {
}); });
if (!parsed.success) { if (!parsed.success) {
const error = parsed.error.issues[0].message; const firstIssue = parsed.error.issues[0];
const path = firstIssue.path.length ? firstIssue.path.join(".") : "root";
const error = `${path}: ${firstIssue.message}`;
const issues = parsed.error.issues; const issues = parsed.error.issues;
const hasInstructionsErrors = issues.some((issue) => issue.path[0] === "instructions"); const hasInstructionsErrors = issues.some((issue) => issue.path[0] === "instructions");
@ -159,7 +161,7 @@ export async function POST(request: NextRequest) {
if (imageValidation.valid) { if (imageValidation.valid) {
customImages.push(img); customImages.push(img);
} else { } else {
return rateLimit.sendResponse({ error: imageValidation.error }, imageValidation.status ?? 400); return rateLimit.sendResponse({ error: `Failed to verify custom image: ${imageValidation.error}` }, imageValidation.status ?? 400);
} }
} }
@ -167,8 +169,10 @@ export async function POST(request: NextRequest) {
if (platform === "SWITCH") { if (platform === "SWITCH") {
const portraitValidation = await validateImage(miiPortraitImage); const portraitValidation = await validateImage(miiPortraitImage);
const featuresValidation = await validateImage(miiFeaturesImage); const featuresValidation = await validateImage(miiFeaturesImage);
if (!portraitValidation.valid) return rateLimit.sendResponse({ error: portraitValidation.error }, portraitValidation.status ?? 400); if (!portraitValidation.valid)
if (!featuresValidation.valid) return rateLimit.sendResponse({ error: featuresValidation.error }, featuresValidation.status ?? 400); return rateLimit.sendResponse({ error: `Failed to verify portrait: ${portraitValidation.error}` }, portraitValidation.status ?? 400);
if (!featuresValidation.valid)
return rateLimit.sendResponse({ error: `Failed to verify features: ${featuresValidation.error}` }, featuresValidation.status ?? 400);
} }
const qrBytes = new Uint8Array(qrBytesRaw ?? []); const qrBytes = new Uint8Array(qrBytesRaw ?? []);
@ -242,7 +246,6 @@ export async function POST(request: NextRequest) {
const fileLocation = path.join(miiUploadsDirectory, "mii.png"); const fileLocation = path.join(miiUploadsDirectory, "mii.png");
await fs.writeFile(fileLocation, pngBuffer); await fs.writeFile(fileLocation, pngBuffer);
await generateMetadataImage(miiRecord, session.user?.name!);
} catch (error) { } catch (error) {
// Clean up if something went wrong // Clean up if something went wrong
await prisma.mii.delete({ where: { id: miiRecord.id } }); await prisma.mii.delete({ where: { id: miiRecord.id } });
@ -252,6 +255,13 @@ export async function POST(request: NextRequest) {
return rateLimit.sendResponse({ error: "Failed to download/store Mii portrait/features" }, 500); return rateLimit.sendResponse({ error: "Failed to download/store Mii portrait/features" }, 500);
} }
try {
await generateMetadataImage(miiRecord, session.user?.name!);
} catch (error) {
console.error("Failed to generate metadata image:", error);
Sentry.captureException(error, { extra: { miiId: miiRecord.id, stage: "metadata-image-generation" } });
}
if (platform === "THREE_DS") { if (platform === "THREE_DS") {
try { try {
// Generate a new QR code for aesthetic reasons // Generate a new QR code for aesthetic reasons

View file

@ -17,7 +17,7 @@ import { Mii } from "@prisma/client";
const MIN_IMAGE_DIMENSIONS = [128, 128]; const MIN_IMAGE_DIMENSIONS = [128, 128];
const MAX_IMAGE_DIMENSIONS = [2000, 2000]; const MAX_IMAGE_DIMENSIONS = [2000, 2000];
const MAX_IMAGE_SIZE = 4 * 1024 * 1024; // 4 MB const MAX_IMAGE_SIZE = 8 * 1024 * 1024; // 8 MB
const ALLOWED_MIME_TYPES = ["image/jpeg", "image/png", "image/gif", "image/webp"]; const ALLOWED_MIME_TYPES = ["image/jpeg", "image/png", "image/gif", "image/webp"];
//#region Image validation //#region Image validation